search

electron / fiddle-core

Run fiddles from anywhere, on any Electron release
MIT License
13 stars 16 forks source link

fix: fiddle-core failing spawn on Electron deps #45

Closed codebytere closed 2 years ago

codebytere commented 2 years ago

Closes https://github.com/electron/fiddle/issues/1198. Refs https://github.com/electron/fiddle/pull/1134.

We need to do something similar to what's done here: https://github.com/electron/fiddle-core/blob/e6387a14ec5d97012a49d63f95e9c86aaf6d74c0/src/installer.ts#L348-L355 and https://github.com/electron/fiddle-core/blob/e6387a14ec5d97012a49d63f95e9c86aaf6d74c0/src/installer.ts#L361-L369 on the off chance that any of the dependencies in node_modules themselves bundle Electron.

electron-bot commented 2 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: