search

electron / fiddle

:electron: 🚀 The easiest way to get started with Electron
https://electronjs.org/fiddle
MIT License
7.46k stars 692 forks source link

test: migrate publish button tests to RTL #1618

Closed erikian closed 4 months ago

erikian commented 4 months ago

Ref: #1408.

I'm also adding a helper function that allows us to access class components' instances, since RTL doesn't expose them and a bunch of our tests are messing with component internals directly; that's probably something we should move away from at some point, but for now that helper should make it a bit easier to migrate away from Enzyme.

coveralls commented 4 months ago

Coverage Status

coverage: 87.514% (+0.02%) from 87.495% when pulling e7f4ac0c060d866575837d8269142ebfb5dbc468 on test/rtl-commands-publish-button into d208fb604cecf5a086faba8658019922b3dcb5bb on main.

dsanders11 commented 4 months ago

that's probably something we should move away from at some point, but for now that helper should make it a bit easier to migrate away from Enzyme.

I think this is reasonable. Migrating off of Enzyme will unblock us on other stuff and long-term we can further improve our testing methodology.