search

electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.49k stars 520 forks source link

Add sample test files to templates #138

Closed chadbr closed 7 years ago

chadbr commented 7 years ago

Are there any plans to integrate testing framework(s) into the tool / templates?

I'm thinking in terms of ng test from the angular-cli.

Maybe I'm missing something (new here!)

malept commented 7 years ago

We would welcome a PR to add really basic test files for the angular2 template in https://github.com/electron-userland/electron-forge-templates. They would have to be formatted in whatever the popular convention is for Angular projects.

However, I think what would be even better would be if someone wrote a plugin for angular-cli. There is already progress on a similar plugin for Forge with Ember.

chadbr commented 7 years ago

Yea - last I looked - they removed the plug-ins from cli unfortunately. -- https://github.com/angular/angular-cli/issues/3901

I think they have plans for something else in the future (probably webpack based?)

malept commented 7 years ago

they removed the plug-ins from cli unfortunately.

That is indeed unfortunate.

MarshallOfSound commented 7 years ago

IMO this breaches the scope of electron-forge, our goal is to provide a minimal entry point into Electron, I don't want our templates to become bloated 100 file "boilerplate" style proejcts, I personally find boilerplates ridiculously opinionated, normally way over the top and almost always include way too much, well, boilerplate 😆

If this is something people want we can discuss it over at https://github.com/electron-userland/electron-forge-templates