Closed jfrux closed 7 years ago
So I've updated my issue because it only seems to be affecting the dmg
make target.
@joshuairl What version of electron-forge
is this?
EDIT: Of note in the stack trace it looks like a promise was rejected _promiseRejected
and from a cursory inspection of the transpiled code the .call
is pushing the error onto the promise context (not our code).
Sorry! Appears to be electron-forge@3.0.0
?
@joshuairl I don't see it changing too much but can you update to latest. (3.0.1)
So it's definitely happening because of a "file not found" error on background
or icon
property in electronInstallerDMG
. It's just not showing file not found, or anything of the sorts. It appears to be getting snuffed by a try / catch somewhere.
But it's not a very descriptive error message so took me a bit to debug.
I can try updating to 3.0.1, but it doesn't appear to affect this issue.
When I fixed the paths, it works now.
Yeah, that was what I was inferring this edit 👍
EDIT: Of note in the stack trace it looks like a promise was rejected _promiseRejected and from a cursory inspection of the transpiled code the .call is pushing the error onto the promise context (not our code).
Looks like a bug in one of our babel transpilers, I will try to repro and follow up with them but async/await transpilation might be beyond me 😆
Closing this out for now as it's an upstream babel transpilation issue that afaics has already been fixed (just needed a clean release 😆 )
Please describe your issue: After successfully packaging, and testing my app, I run
electron-forge make
for targetdmg
and I get the error found below. My question is, are these commonly errors in my own code-base or is this something with electron package?*Console output when you run
electron-forge
with the environment variable `DEBUG=electron-forge:`. (Instructions on how to do so here). Please include the stack trace if one exists.**What command line arguments are you passing?
What does your
config.forge
data inpackage.json
look like?