Remove hardcoded `node_modules` - Githubissues

electron / forge

:electron: A complete tool for building and publishing Electron applications

https://electronforge.io

MIT License

6.32k stars 491 forks source link

Remove hardcoded `node_modules` #3630

Open rtritto opened 1 week ago

rtritto commented 1 week ago

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.4.0

Electron version

31.0.1

Operating system

Windows 11

Last known working Electron Forge version

No response

Expected behavior

node_modules isn't used

Actual behavior

node_modules is used

Steps to reproduce

git clone https://github.com/rtritto/template-electron-vite.git
cd template-electron-vite
yarn
yarn start
node_modules/.vite foders is created even if cacheDir is .vite/cache (issue https://github.com/vitejs/vite/issues/17491)

Additional information

This issue also create some problem with Plug'n'Play (PnP) node linker.

rtritto commented 1 week ago

FYI @erickzhao @dsanders11 @caoxiemeihao