electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.41k stars 505 forks source link

Wix Maker - Expose Associate Extensions #3673

Open fras2560 opened 2 weeks ago

fras2560 commented 2 weeks ago

Pre-flight checklist

Problem description

The Wix MSI Creator has an option for assoicateExtensions. This allows one to specify file extensions.

Proposed solution

Expose the option - It is a comma separated string

Alternatives considered

When using the Wix Maker just extend the maker wix config interface and pass it the value even though it is not documented:

interface ExtendedMakerWixConfig extends MakerWixConfig {
  associateExtensions?: string;
}

Now can pass the icon. The only note is that have to use the full path for the icon (cannot use relative path).

Additional information

No response

fras2560 commented 2 weeks ago

https://github.com/electron/forge/pull/3674

siadou commented 2 weeks ago

same with the cultures option