electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.51k stars 520 forks source link

Electron Forge resolving path to node module using absolute path rather than using relative path in production #3691

Open ec2-learn-instant opened 2 months ago

ec2-learn-instant commented 2 months ago

Pre-flight checklist

Electron Forge version

7.4.0

Electron version

30.5.0

Operating system

Windows 10

Last known working Electron Forge version

No response

Expected behavior

I'm trying to create an app that include the get-windows npm package, it's properly working in development mode. After I make production build, it throws error, reason beacuse its takes the development path in production build

Actual behavior

[error] (node:13140) UnhandledPromiseRejectionWarning: Error: D:\VMKV\electron-app\node_modules\get-windows\package.jsondoes not exist at t.find (C:\Users\Quick App Studio\AppData\Local\Programs\my-electron-app\resources\app.asar.webpack\main\index.js:2:3391) at p (C:\Users\Quick App Studio\AppData\Local\Programs\my-electron-app\resources\app.asar.webpack\main\index.js:2:1654721) at m (C:\Users\Quick App Studio\AppData\Local\Programs\my-electron-app\resources\app.asar.webpack\main\index.js:2:1654862) at Module.n (C:\Users\Quick App Studio\AppData\Local\Programs\my-electron-app\resources\app.asar.webpack\main\index.js:2:1649771) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async App. (C:\Users\Quick App Studio\AppData\Local\Programs\my-electron-app\resources\app.asar.webpack\main\index.js:2:13148557)

Steps to reproduce

Also note, I am using the following versions:

Node: 20.16.0 Electron: ^30.5.0 electron-forge/cli: ^7.4.0 get-windows: ^9.2.0

Please let me know if there's any missing info.

Additional information

No response

rtritto commented 2 months ago

3209 probably related

bearsworth commented 2 weeks ago

I have this issue too. I am not sure why it takes the absolute path rather than the relative path. Same exact package too oddly enough. If anyone finds a work around, please leave it here!