electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.5k stars 520 forks source link

feat(makerdeb): Add name option and fix bin name #3726

Open coredev-uk opened 1 month ago

coredev-uk commented 1 month ago

Summarize your changes: Basically as the title says, this implements a rename function to correct the file name of the .deb output to the user specified value. This also corrects the bin name to enforce the use of the executableName. In situations where the app name in the package.json does not match the executableName in the packagerConfig it errors due to package generating an executable following the executableName value which is not what MakerDeb is expecting.

coredev-uk commented 1 month ago

I might adapt this PR to allow the user to change the full name (AppName, Version and Arch) for all the makers, similar to how it is done in the ReForged AppImage Maker. Even though the naming option is not something that really effects the user, it removes the step in any release workflow, making it easier for everyone.

felixrieseberg commented 1 month ago

This looks good, thanks for the contribution @coredev-uk! The only question I have is whether or not this might be a breaking change for anyone - what's your take?

coredev-uk commented 1 month ago

This does slightly change the default file name, current structure is $NAME-$PLATFORM-$ARCH-$VERSION-$DEBARCH.deb, this PR does change it to a simpler format which could potentially cause some issues in a CI environment if people are explicitly setting the filename. Would you suggest I set the default to the current one?