electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.51k stars 520 forks source link

feat(publisher-s3): allow ACL omission #3728

Closed JHartman5 closed 1 week ago

JHartman5 commented 1 month ago

This allows the caller to omit the ACL from the upload request, per Amazon's recommendation of using bucket owner-enforced permissions.

Summarize your changes:

AWS recommends disabling the use of ACLs and instead using bucket owner-enforced permissions (see https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html). The current configuration and implementation of the S3 publisher always applies an ACL, which simply doesn't work with buckets configured this way. This PR adds an omitAcl option to the config that simply omits the ACL from the upload command.

I considered making this config look more like the Google Cloud Storage publisher (which uses essentially applies some of its options, such as predefinedAcl, public, and private, directly to its upload object); however, that would be a breaking change, and I opted for keeping this non-breaking. I'm happy to refactor if you think that is preferred.

JHartman5 commented 1 month ago

Added your comment, @felixrieseberg. Thank you!