electron / forge

:electron: A complete tool for building and publishing Electron applications
https://electronforge.io
MIT License
6.51k stars 520 forks source link

fix(plugin-vite): stop the world #3736

Open smallsung opened 1 month ago

smallsung commented 1 month ago

Summarize your changes: Run yarn run start. Under the default configuration, vite.build will call rollup.watch. If the first build fails, Promise.all will never be resolved.

https://github.com/electron/forge/blob/7574b364901ec429220dbe7076184585a99529a5/packages/plugin/vite/src/VitePlugin.ts#L155-L183

georgexu99 commented 1 week ago

Can we edit the description to be more in-depth? Thanks!