search

electron / fuses

MIT License
42 stars 16 forks source link

fix: fix broken resetAdHocDarwinSignature option #9

Closed Hans-Halverson closed 2 years ago

Hans-Halverson commented 2 years ago

The resetAdHocDarwinSignature option was broken by the changes in https://github.com/electron/fuses/commit/b9293a7e92dafc791ce1b9ceb903f5f1552d7307 due to returning early from flipFuses, skipping the handling of this option. Let's fix this by avoiding the early return.

This issues is present in version 1.6.0 of @electron/fuses on NPM, which is how I ran across this issue.

Tested by setting the resetAdHocDarwinSignature option when flipping fuses on an ARM64 Mac, the resulting binary can now be run successfully instead of running into code signing errors.

Hans-Halverson commented 2 years ago

cc @MarshallOfSound This issue is currently present in version 1.6.0 on NPM. Would you be able to take a look, or direct me to a more appropriate reviewer? Let me know if there is some other channel/protocol I should be using for this PR, I didn't see PR guidance in this repo. Thank you!

electron-bot commented 2 years ago

:tada: This PR is included in version 1.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: