search

electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
338 stars 106 forks source link

feat: add an option to remove / use the 'v' prefix when normalizing the version #134

Closed MarshallOfSound closed 4 years ago

MarshallOfSound commented 4 years ago

Closes #123 Closes #120

nickfan commented 4 years ago

Closes #123 Closes #120

the problem is the normalizeVersion apply to the custom_dir and filename part of the download URL.

but for taobao mirror it only use verion number without 'v' prefix for the custom_dir part but not for the file name part.

in 7.0.0 https://npm.taobao.org/mirrors/electron/v7.0.0/electron-v7.0.0-darwin-x64.zip in 6.1.2 https://npm.taobao.org/mirrors/electron/6.1.2/electron-v6.1.2-darwin-x64.zip

electron-v6.1.2-darwin-x64.zip and /6.1.2/ in the dir part.

so for 7.0.0 electron-v7.0.0-darwin-x64.zip and /7.0.0/ in the dir part.

i think maybe split ELECTRON_GET_NO_V_PREFIX into

ELECTRON_GET_NO_V_PREFIX_CUSTOM_DIR

ELECTRON_GET_NO_V_PREFIX_FILENAME

may solve the problem.

@MarshallOfSound

electron-bot commented 4 years ago

:tada: This issue has been resolved in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: