electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
338 stars 106 forks source link

Url get Bug #153

Closed shenlanchenwei closed 4 years ago

shenlanchenwei commented 4 years ago

There is an error in the address, and a "V" is added, which causes an error.

shenlanchenwei commented 4 years ago

image

vhashimotoo commented 4 years ago

Please see electronjs.org/docs/tutorial/installation#mirror for mirror instructions.

Can you please check these:

ELECTRON_MIRROR="https://cdn.npm.taobao.org/dist/electron/"

or

ELECTRON_MIRROR="https://npm.taobao.org/mirrors/electron/"
ELECTRON_CUSTOM_DIR="{{ version }}"
shenlanchenwei commented 4 years ago

thanks

aprilandjan commented 2 years ago

ELECTRON_MIRROR="https://cdn.npm.taobao.org/dist/electron/"

Just want to say that the first part

ELECTRON_MIRROR="https://cdn.npm.taobao.org/dist/electron/"

is ok for download, but the second part

ELECTRON_MIRROR="https://npm.taobao.org/mirrors/electron/"
ELECTRON_CUSTOM_DIR="{{ version }}"

is not able for download because the real customDir is infact v{{ version }}. To be honest, the instruction is somehow misleading. Many people(me included) are anxious to find a solution and will not read the instructions carefully at first glance.