search

electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
338 stars 106 forks source link

Easily hitting long file paths on Windows #185

Closed joaomoreno closed 3 years ago

joaomoreno commented 3 years ago

It's extremely easy to hit long file paths errors in the cache on Windows:

https://github.com/electron/get/blob/42d964b9bcc2be1d10b472f20ae6395f7423dd76/src/Cache.ts#L21

We should rather come up with something different here, in order to make the file path shorter: ie take the filename of the URL (for easy cache debugging) as well as a short hash checksum of the entire URL (for uniqueness).

electron-bot commented 3 years ago

:tada: This issue has been resolved in version 1.12.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: