electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
338 stars 106 forks source link

chore: ignore .idea directory in git #229

Closed BlackHole1 closed 7 months ago

BlackHole1 commented 2 years ago

I'd argue that either you put this in your global .gitignore, or we ignore all editors' specific directories/files. I'm generally more in favor of the former.

It may not be a good idea to put it globally, as the .idea has a role in some projects (e.g. debug). See: https://github.com/netless-io/flat/blob/main/docs/debugging/electron/README.md#webstorm

Although .idea and .vscode are the same in nature, there are many more files in .idea than in .vscode, which is the main reason why many projects don't put .idea in git.

I can submit another PR to migrate the vscode configuration from the project to the .editorconfig file.

continuous-auth[bot] commented 2 months ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: