search

electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
338 stars 106 forks source link

fix: update dependencies to clean up yarn audit #234

Closed MarshallOfSound closed 10 months ago

MarshallOfSound commented 1 year ago

BREAKING CHANGE: The minimum supported node version is now node 14

This PR also as a side effect ensures tests can pass / run on M1 hardware.

BlackHole1 commented 1 year ago

CI failed. Reason: error @continuous-auth/semantic-release-npm@3.0.0: The engine "node" is incompatible with this module. Expected version ">=16 || ^14.17". Got "12.13.1".

Restoration Solutions:

  1. Use --ignore-engines In CI. Since only devDependencies are upgraded, it does not affect the end-users.
  2. Fallback @continuous-auth/semantic-release-npm version
  3. Modifdy https://github.com/electron/get/blob/main/package.json#L26 to >=16
BlackHole1 commented 1 year ago

CI failed again.

image

Optional Chaining was not implemented until after nodejs version 14

continuous-auth[bot] commented 10 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: