search

electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
337 stars 106 forks source link

Download Progress Bar #280

Closed botPuneet closed 4 months ago

botPuneet commented 4 months ago

Created PR to resolve issue #issue

dsanders11 commented 4 months ago

Thanks for the PR, but I don't think this is the right approach to solving electron/fiddle-core#59. @marfgold1 has shown the bug is due to redirects and invalid values for total. This PR would lead to NaN in those cases.

botPuneet commented 4 months ago

Sorry @dsanders11 sir i have misunderstood the problem. thank u for the feedback. just one question is this issue still open?

Thanks for the PR, but I don't think this is the right approach to solving electron/fiddle-core#59. @marfgold1 has shown the bug is due to redirects and invalid values for total. This PR would lead to NaN in those cases.