search

electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
344 stars 105 forks source link

back port sumchecker 2.0.2 to 3.x #66

Closed wojtkowiak closed 6 years ago

wojtkowiak commented 6 years ago

Hello could you backport sumcheck upgrade to 3.x version? On node 8 it not possible to download electron as I am getting: Error: Generated checksum for "chromedriver-v2.21-win32-x64.zip" did not match expected checksum.

In sumchecker 2 it was fixed https://github.com/malept/sumchecker/issues/7

I see that:

+--  electron@1.7.9
| `--  electron-download@3.3.0
|   `--  sumchecker@1.3.1

but since electron has reverted the update to electron-download 4 for a reason (https://github.com/electron/electron/commit/6f3fdb6ae6b5b3a0e55696d80f88b8f680bc5eac) I am asking here 🙂

malept commented 6 years ago

The fix for Node 8 was backported in sumchecker 1.3.1: https://github.com/malept/sumchecker/releases/tag/v1.3.1

You should run npm update for electron-download.