electron / get

Download Electron release artifacts
https://npm.im/@electron/get
MIT License
338 stars 106 forks source link

Electron version-based regressions #96

Closed malept closed 5 years ago

malept commented 5 years ago

While trying to get Electron Packager switched over to use @electron/get instead of electron-download, I found some regressions related to Electron versions:

The second bullet point is causing Electron Packager tests to fail.

I suppose the question becomes, what Electron versions should tools support? (Which inevitably becomes a topic for the Docs & Tools WG...) Electron Packager tries to support as many Electron versions as possible; there are still some conditionals for the super-ancient 0.37.x series.

malept commented 5 years ago

We discussed this in the Docs & Tools WG meeting today. We're going to only "officially" support the versions of Electron officially supported by the Electron team. If it happens to work with earlier versions, that's great, but we're not going to be actively supporting old versions (as in the examples above).