fix mime type error for es6 modules

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

486 stars 183 forks source link

fix mime type error for es6 modules #459

Closed codebytere closed 6 years ago

codebytere commented 6 years ago

Fixes https://github.com/electron/electron/issues/12011.

Patch chromium commit to fix es6 loading bug that caused

Failed to load module script: The server responded with a non-JavaScript MIME type of "". Strict MIME type checking is enforced for module scripts per HTML spec.

to be thrown when es6 modules attempted to be loaded.

/cc @MarshallOfSound

deepak1556 commented 6 years ago

@codebytere We don't rely on extension protocol handler from chromium for chrome-extension or any other scheme. This patch shouldn't be fixing the issue. Also can you verify if the issue is only with custom protocols and file scheme, the referenced issue doesn't expand on any of the details. If so, the fix should be in protocol implementation of Electron.