Light refactoring of patches related code

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

486 stars 183 forks source link

Light refactoring of patches related code #468

Closed alexeykuzmin closed 6 years ago

alexeykuzmin commented 6 years ago

The intention is to move all patches related meta info (owner, description, etc.) in a dedicated config. It will also help us to avoid patches' name and position collisions.

This PR is just a preparation for the bigger change and only includes the following:

create Patch, PatchesList, and PatchesConfig classes
use Patch and PatchesList in patch.py script
slightly improve apply-patches script

/cc @zcbenz, @alespergl

UPD next PRs: #470

zcbenz commented 6 years ago

The code that's here looks fine, but it looks like a WIP at the moment. Are you sure you want to merge this now?

I understand this PR as part of a series of big refactors, separated to make review easier.

alexeykuzmin commented 6 years ago

I understand this PR as part of a series of big refactors, separated to make review easier.

Exactly. There only two options how huge PRs are reviewed: they are either approved blindly, without any actual review ("it seems like this guy knows that he's doing... yeah, ok") or they stay unreviewed for days and weeks.