Closed zcbenz closed 6 years ago
I have added another patch to fix crash on macOS:
[63904:0307/123147.745744:FATAL:Node.cpp(2438)] Check failed: !IsPseudoElement().
0 libbase.dylib base::debug::StackTrace::StackTrace(unsigned long) + 174
1 libbase.dylib base::debug::StackTrace::StackTrace(unsigned long) + 29
2 libbase.dylib base::debug::StackTrace::StackTrace() + 28
3 libbase.dylib logging::LogMessage::~LogMessage() + 479
4 libbase.dylib logging::LogMessage::~LogMessage() + 21
5 libblink_core.dylib blink::Node::AssignedSlot() const + 194
6 libblink_core.dylib blink::StyleResolver::MatchScopedRules(blink::Element const&, blink::ElementRuleCollector&) + 1696
7 libblink_core.dylib blink::StyleResolver::MatchScopedRules(blink::Element const&, blink::ElementRuleCollector&) + 126
8 libblink_core.dylib blink::StyleResolver::MatchAuthorRules(blink::Element const&, blink::ElementRuleCollector&) + 105
9 libblink_core.dylib blink::StyleResolver::MatchAllRules(blink::StyleResolverState&, blink::ElementRuleCollector&, bool) + 368
10 libblink_core.dylib blink::StyleResolver::StyleForElement(blink::Element*, blink::ComputedStyle const*, blink::ComputedStyle const*, blink::RuleMatchingBehavior) + 2030
11 libblink_core.dylib blink::Element::OriginalStyleForLayoutObject() + 303
12 libblink_core.dylib blink::Element::StyleForLayoutObject() + 435
13 libblink_core.dylib blink::Element::RecalcOwnStyle(blink::StyleRecalcChange) + 807
We should be enabling them, not disabling more of them. 😃
Saw crash when running tests on Linux: