electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Disable DCHECK in program_binding.h #471

Closed zcbenz closed 6 years ago

zcbenz commented 6 years ago

Saw crash when running tests on Linux:

[4499:0307/103701.363973:FATAL:program_binding.h(419)] Check failed: IsContextLost(context_provider->ContextGL()).
0 0x7f4eb77c318d base::debug::StackTrace::StackTrace()
1 0x7f4eb77c155c base::debug::StackTrace::StackTrace()
2 0x7f4eb7851caa logging::LogMessage::~LogMessage()
3 0x7f4ec03b850a <unknown>
4 0x7f4ec03b38e7 <unknown>
5 0x7f4ec039ff4d viz::GLRenderer::SetUseProgram()
6 0x7f4ec03959f3 viz::GLRenderer::SetUseProgram()
7 0x7f4ec0391a64 viz::GLRenderer::DrawSolidColorQuad()
8 0x7f4ec03905db viz::GLRenderer::DoDrawQuad()
9 0x7f4eb6f15bc8 cc::DirectRenderer::DrawRenderPass()
10 0x7f4eb6f14316 cc::DirectRenderer::DrawRenderPassAndExecuteCopyRequests()
11 0x7f4eb6f13d24 cc::DirectRenderer::DrawFrame()
12 0x7f4ec0371f8d viz::Display::DrawAndSwap()
13 0x7f4ec037fcfe viz::DisplayScheduler::DrawAndSwap()
14 0x7f4ec037ec16 viz::DisplayScheduler::AttemptDrawAndSwap()
15 0x7f4ec037e50f viz::DisplayScheduler::OnBeginFrameDeadline()
zcbenz commented 6 years ago

I have added another patch to fix crash on macOS:

[63904:0307/123147.745744:FATAL:Node.cpp(2438)] Check failed: !IsPseudoElement().
0   libbase.dylib        base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib        base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib        base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib        logging::LogMessage::~LogMessage() + 479
4   libbase.dylib        logging::LogMessage::~LogMessage() + 21
5   libblink_core.dylib  blink::Node::AssignedSlot() const + 194
6   libblink_core.dylib  blink::StyleResolver::MatchScopedRules(blink::Element const&, blink::ElementRuleCollector&) + 1696
7   libblink_core.dylib  blink::StyleResolver::MatchScopedRules(blink::Element const&, blink::ElementRuleCollector&) + 126
8   libblink_core.dylib  blink::StyleResolver::MatchAuthorRules(blink::Element const&, blink::ElementRuleCollector&) + 105
9   libblink_core.dylib  blink::StyleResolver::MatchAllRules(blink::StyleResolverState&, blink::ElementRuleCollector&, bool) + 368
10  libblink_core.dylib  blink::StyleResolver::StyleForElement(blink::Element*, blink::ComputedStyle const*, blink::ComputedStyle const*, blink::RuleMatchingBehavior) + 2030
11  libblink_core.dylib  blink::Element::OriginalStyleForLayoutObject() + 303
12  libblink_core.dylib  blink::Element::StyleForLayoutObject() + 435
13  libblink_core.dylib  blink::Element::RecalcOwnStyle(blink::StyleRecalcChange) + 807
alespergl commented 6 years ago

We should be enabling them, not disabling more of them. 😃