search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

[1-8-x]: Re-enable accelerated 2D Canvas on NVidia High Sierra #490

Closed deepak1556 closed 6 years ago

deepak1556 commented 6 years ago

Backports https://github.com/electron/libchromiumcontent/pull/489

ckerr commented 6 years ago

Static builds are dying:

ninja: warning: multiple rules generate static_library/libGLESv2.dll.pdb. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
ninja: warning: multiple rules generate D:/build/dist/main/src/content/common/content_export.h. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
deepak1556 commented 6 years ago

@ckerr that warning is actually present for quite some time for ex: https://windows-ci.electronjs.org/project/AppVeyor/libchromiumcontent/build/1.0.903/job/ae0m6lxowu34j0y1, not related to this PR. The actual issue seems to be

[1/1] libchromiumcontent-static.zip (5,932,107,199 bytes)...90%Error uploading artifact the storage: You must write ContentLength bytes to the request stream before calling [Begin]GetResponse.

seems like a flake, can we try restarting the static builds ?

jkleinsc commented 6 years ago

I'm going to merge this as the only failed builds are the appveyor/branch builds, but the appveyor/pr build (which is the one that really matters), passed.