search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

Add a patch to fix window repainting issues when DWM is disabled on Windows #503

Closed brenca closed 6 years ago

brenca commented 6 years ago

Fixes electron/electron#1821, sister PR coming up on that repo

When DWM is disabled, chromium uses a custom window title implementation (this can be observed by running Chrome on Windows7 with the aero theme disabled). The code is written to assume that that's what's happening, but electron is forcing a native titlebar, and that causes problems, since chromium does some hacky stuff to ensure that the custom titlebar always works perfectly. That hacky stuff blocks the native titlebar (and the whole window in fact) from rendering correctly. This patch adds a way to disable the lock.

brenca commented 6 years ago

@alexeykuzmin Should I add a description to .patches.yaml too?

alexeykuzmin commented 6 years ago

Should I add a description to .patches.yaml too?

@brenca It would be great. Thanks! Having a detailed explanation in the PR is nice, but it might be difficult to find it, especially if the patch contents change over time.

brenca commented 6 years ago

@alexeykuzmin I'm ready for another review :) BTW this .patches.yaml file is a pretty nice addition, it's much easier to see what patch does what this way. (I haven't seen it before, a long time has gone by since I added any patches :) )

There are some other patches that I authored, I can add descriptions in a separate PR for those if you want.

alexeykuzmin commented 6 years ago

a long time has gone by since I added any patches :)

Welcome back! =)

There are some other patches that I authored, I can add descriptions in a separate PR for those if you want.

That would be great! But please do it in a separate PR if you don't mind )

alexeykuzmin commented 6 years ago

I just restarted the Windows builds, after they finish we should be good to merge.

brenca commented 6 years ago

There are some other patches that I authored, I can add descriptions in a separate PR for those if you want.

That would be great! But please do it in a separate PR if you don't mind )

Sure, that was my intention, I don't want to pollute this PR with more changes :)

zanderz commented 6 years ago

:thumbsup: