electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Add flag for enabling sccache #513

Closed MarshallOfSound closed 6 years ago

MarshallOfSound commented 6 years ago

Use with --sccache

alexeykuzmin commented 6 years ago

We should expose cc_wrapper rather than hardcoding sccache, it might make sense to use some other wrapper/s, e.g. regular ccache.

I think that having --sccache as a shortcut for --cc_wrapper=sccache is a good thing.

alexeykuzmin commented 6 years ago

I think that having --sccache as a shortcut for --cc_wrapper=sccache is a good thing.

I mean something like that:

cc_wrapper_group = parser.add_mutually_exclusive_group()
cc_wrapper_group.add_argument('--cc_wrapper', help="...")
cc_wrapper_group.add_argument('--ccache',
                              action='store_const', const='ccache', dest='cc_wrapper',
                              help="...")
cc_wrapper_group.add_argument('--sccache',
                              action='store_const', const='sccache', dest='cc_wrapper',
                              help="...")
alexeykuzmin commented 6 years ago

We should expose cc_wrapper rather than hardcoding sccache, it might make sense to use some other wrapper/s, e.g. regular ccache.

@nornagon done