search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Add flag to cache libcc downloads #514

Closed MarshallOfSound closed 6 years ago

MarshallOfSound commented 6 years ago

Will need a follow up PR to electron to allow usage of this, basically you can optionally cache libcc downloads to a folder on your machine. Means that when you switch branch you won't have to redownload stuff.

alexeykuzmin commented 6 years ago

Would it make sense to give unique local names to already downloaded libcc archives to avoid redownload?

(In that case we would have to limit total number/size of libcc archives though.)

MarshallOfSound commented 6 years ago

Would it make sense to give unique local names to already downloaded libcc archives to avoid redownload?

What do you mean, all libcc downloads are stored at {commit}-{filename} so they won't redownload 🤔

alexeykuzmin commented 6 years ago

What do you mean, all libcc downloads are stored at {commit}-{filename} so they won't redownload 🤔

@MarshallOfSound Sorry, I didn't read your changes as carefully as I should have. That's exactly what you're doing.