search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Bundle sccache binaries #516

Closed alexeykuzmin closed 6 years ago

alexeykuzmin commented 6 years ago

Run ./script/update --use-bundled-sccache to use it.

/cc @jkleinsc

alexeykuzmin commented 6 years ago

FIXME: Try to run bundled sccache

sccache --version works fine on Windows and Linux, Mac fails with dyld: Library not loaded: /usr/local/opt/openssl@1.1/lib/libssl.1.1.dylib error.

MarshallOfSound commented 6 years ago

@alexeykuzmin Where did the prebuilt's come from, they need to come from my hashing branch if we want the hashing to work across machines 🤔

alexeykuzmin commented 6 years ago

@MarshallOfSound https://github.com/mozilla/sccache/releases/tag/0.2.6

alexeykuzmin commented 6 years ago

if we want the hashing to work across machines

Honestly I don't even understand what you're talking about )

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-mas-shared succeeded for cfe09abcbfc2e64d5606647d862be226f59f48bf. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-osx-shared succeeded for cfe09abcbfc2e64d5606647d862be226f59f48bf. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-osx-static succeeded for cfe09abcbfc2e64d5606647d862be226f59f48bf. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-mas-static succeeded for cfe09abcbfc2e64d5606647d862be226f59f48bf. Details

alexeykuzmin commented 6 years ago

@MarshallOfSound Let's use these binaries for now, they won't allow us to do two-tier caching but simple caching is better than nothing =)

alexeykuzmin commented 6 years ago

Mac fails with dyld: Library not loaded: /usr/local/opt/openssl@1.1/lib/libssl.1.1.dylib error

Everything's ok now. sccache statically linked with the openssl works well.

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-mas-shared succeeded for 6d31f0033fa275ea52cf0fb6f356275fb0930450. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-osx-shared succeeded for 6d31f0033fa275ea52cf0fb6f356275fb0930450. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-osx-static succeeded for 6d31f0033fa275ea52cf0fb6f356275fb0930450. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-mas-static succeeded for 6d31f0033fa275ea52cf0fb6f356275fb0930450. Details

alespergl commented 6 years ago

@alexeykuzmin @jkleinsc @MarshallOfSound Wasn't there a better way to fetch these binaries on demand, rather than adding them into the Git history?

alexeykuzmin commented 6 years ago

@alespergl it's 25MB of binaries combined. I probably could make them entirely optional: like put them in an external storage, add a script to fetch them when they're needed and so on, but it would be too complicated.

I totally understand your concern though. If we continue to add more stuff in the repo, eventually it will become huge and slow, and we definitely don't want it to happen.