search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

Fix PR builds for Mac #526

Closed jkleinsc closed 6 years ago

jkleinsc commented 6 years ago

Visual Studio Team Services builds PRs by merging the commit(s) into the target branch and then building that. Unfortunately this ends up putting PR builds in the wrong location on S3 as well as it produces issues for WIP PRs such as our Chromium upgrades.

This PR will do the following:

  1. If the build is not a PR build, it will build the commit.
  2. If the build is a PR build, but for a fork, it will build against the result of merging the commit(s) into the target branch.
  3. If the build is a PR build from a branch in this repo, it will build the original commit instead of the merge.
electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-mas-shared succeeded for 261fc5db281b7e20be76b4449bf4ed2fc00f3c78. Details

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-osx-static succeeded for 261fc5db281b7e20be76b4449bf4ed2fc00f3c78. [Details](https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent/osx/x64/ 9c21378124b2c84633f502e8709de6ecd1d77021 /buildlog.txt)

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-osx-shared succeeded for 261fc5db281b7e20be76b4449bf4ed2fc00f3c78. [Details](https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent/osx/x64/ 9c21378124b2c84633f502e8709de6ecd1d77021 /buildlog.txt)

electron-bot commented 6 years ago

:white_check_mark: libchromiumcontent-mas-static succeeded for 261fc5db281b7e20be76b4449bf4ed2fc00f3c78. [Details](https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent/mas/x64/ 9c21378124b2c84633f502e8709de6ecd1d77021 /buildlog.txt)