electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Add a patch to fix long jitter buffer delays with Opus and DTX (2.0.x edition) #533

Closed ajmacd closed 6 years ago

ajmacd commented 6 years ago

This brings the patch in #532 to electron-2-0-x.

ajmacd commented 6 years ago

As mentioned in #532 this is a critical issue for WebRTC services using DTX. We should try to get it in Electron 2.0.x.

alexeykuzmin commented 6 years ago

@ajmacd The patch has exactly the same changes as the upstream repo, with no modifications, right?

alexeykuzmin commented 6 years ago

The main discussion should probably take place at #532

@ckerr Sure. But patches for different Chromium versions might be different. Quite often we can backport a change to one branch without any trouble, but have to make some changes to backport it to another branch.

ajmacd commented 6 years ago

@alexeykuzmin Good point. At least in this case, the changes were identical to 2-0-x and master.