electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

Add a pre-commit hook to check lists of patches on disk and in .patches.yaml files #541

Closed alexeykuzmin closed 5 years ago

nornagon commented 6 years ago

It'd be awesome if such a precommit would also check that the patches are correctly formatted, possibly by parsing them with something like the unidiff python library, and that there are no patches in the folder that aren't also present in the YAML.

MarshallOfSound commented 5 years ago

Hey there,

It's been a long time coming but the libchromiumcontent repository is being archived as it is no longer used in the Electron build system (🎉 this is a good thing).

If your issue is still relevant to Electron in it's current build system (please verify first) then you should probably raise a similar issue on electron/electron.

Thanks 😄