electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

[WIP] Add patch to fix some guestinstance tests #551

Closed codebytere closed 6 years ago

codebytere commented 6 years ago

After enabling verbose logging, it appeared that some guestinstance tests were crashing as a result of

[25755:0522/121849.511223:ERROR:sync_point_manager.cc(136)] Client did not release sync token as expected

errors.

This error was also seen here, and subsequently repaired in chromium with this CL, which is the patch i've backported in this PR.

/cc @alexeykuzmin @deepak1556

alexeykuzmin commented 6 years ago

> backport_3743d0f.patch failed to apply =(

alexeykuzmin commented 6 years ago

There is no need to backport commit 3743d0f, it has already been backported to M66 in commit 4ec34bb.

alexeykuzmin commented 6 years ago

https://chromium-review.googlesource.com/c/chromium/src/+/969968 should also be backported.

I'll do it separately.