search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

Revert "Disable a DCHECK in process_metrics_win.cc" #573

Closed torycl closed 6 years ago

torycl commented 6 years ago

This reverts commit b9a68acb7e1f93193540cdf94f73ad6ba22c7900.

It seems this DCHECK is ok and should be reenabled now. Electron doesn't crash with this DCHECK being enabled: https://windows-ci.electronjs.org/project/AppVeyor/electron/build/1.0.5964

Fixes electron/electron#13317.

alexeykuzmin commented 6 years ago

Electron builds with this DCHECK do not crash: https://windows-ci.electronjs.org/project/AppVeyor/electron/build/1.0.5964

zcbenz commented 6 years ago

@torycl @alexeykuzmin After building Electron with this change included, I'm seeing this crash at https://windows-ci.electronjs.org/project/AppVeyor/electron/build/1.0.6142.

The PR including the change is https://github.com/electron/electron/pull/13475.

python : [3336:0628/041653.182:FATAL:process_metrics_win.cc(332)] Check failed: result. 
2883At line:11 char:3
2884+   python script\verify-ffmpeg.py
2885+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2886    + CategoryInfo          : NotSpecified: ([3336:0628/0416...ailed: result. :String) [], RemoteException
2887    + FullyQualifiedErrorId : NativeCommandError
2888 
2889Backtrace:
2890    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7BBD275+416889]
2891    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7BBD218+416796]
2892    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7C75F00+1173764]
2893    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7D1A1C0+1846212]
2894    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7D35934+1958712]
2895    atom::api::App::ChildProcessLaunched [0x00007FF7568DB58F+79] (c:\projects\electron\atom\browser\api\atom_api_app.cc:816)
2896    atom::api::App::BrowserChildProcessLaunchedAndConnected [0x00007FF7568DA204+68] (c:\projects\electron\atom\browser\api\atom_api_app.cc:780)
2897    content::CacheStorage::MatchCache [0x00007FFCCD3455E1+30493824]
2898    content::CacheStorage::MatchCache [0x00007FFCCD23D03F+29411038]
2899    content::CacheStorage::MatchCache [0x00007FFCCD24C607+29473958]
2900    content::CacheStorage::MatchCache [0x00007FFCCD2572FC+29518235]
2901    content::CacheStorage::MatchCache [0x00007FFCCD37241D+30677692]
2902    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7BFC640+675908]
2903    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7BFD6ED+680177]
2904    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7CA9669+1384557]
2905    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7CA99AD+1385393]
2906    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7C90940+1282884]
2907    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7C93642+1294406]
2908    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7C93021+1292837]
2909    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7CA932D+1383729]
2910    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7CA9061+1383013]
2911    base::trace_event::MemoryAllocatorDump::AddString [0x00007FFCD7DE62BC+2682048]
2912    content::CacheStorage::MatchCache [0x00007FFCCD33F6F8+30469527]
2913    content::CacheStorage::MatchCache [0x00007FFCCD371F97+30676534]
2914    content::CacheStorage::MatchCache [0x00007FFCCD371120+30672831]
2915    content::CacheStorage::MatchCache [0x00007FFCCD30B01E+30254781]
2916    content::CacheStorage::MatchCache [0x00007FFCCFF41E64+76616963]
2917    content::CacheStorage::MatchCache [0x00007FFCCFF41CCD+76616556]
2918    content::CacheStorage::MatchCache [0x00007FFCCFF3C4BF+76594014]
2919    service_manager::EmbeddedInstanceManager::QuitOnServiceSequence [0x00007FFCBDF55FEE+216976]
2920    content::CacheStorage::MatchCache [0x00007FFCCFF3EC56+76604149]
2921    wWinMain [0x00007FF75684A246+998] (c:\projects\electron\atom\app\atom_main.cc:153)
2922    invoke_main [0x00007FF7570A1F4D+45] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:123)
2923    __scrt_common_main_seh [0x00007FF7570A1E77+295] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
2924    __scrt_common_main [0x00007FF7570A1D3E+14] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
2925    wWinMainCRTStartup [0x00007FF7570A1FC9+9] (f:\dd\vctools\crt\vcstartup\src\startup\exe_wwinmain.cpp:17)
2926    BaseThreadInitThunk [0x00007FFCF83113D2+34]
2927    RtlUserThreadStart [0x00007FFCFA3954F4+52]
2928
alexeykuzmin commented 6 years ago

@zcbenz Must be not stable then, I've run Electron builds with this change several times and didn't see a single crash. I'll revert it for now then. Thank you!