electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Fix assertion when preventDefault is called for new-window #583

Closed zcbenz closed 6 years ago

zcbenz commented 6 years ago

Refs https://github.com/electron/electron/issues/13316.

A recent Chromium change has accidentally added assertion for the case when a new window object may not have a prototype attached. In Electron it may happen when preventDefault for a native new-window event. https://chromium.googlesource.com/chromium/src/+/f47b361887a31cccf42a6e21a82bccf28372bdaa%5E%21

In the long term we should investigate why it happened, and take a more formal fix. But for now I'm just make this assertion silently pass away.