search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

Disable DCHECKs related to ScrollBegin event #589

Closed zcbenz closed 6 years ago

zcbenz commented 6 years ago

When testing https://github.com/electron/electron/issues/13137 I have encountered these assertions. I grouped them together since they are all related to the ScrollBegin event.

alexeykuzmin commented 6 years ago

Any idea why we hit it?

zcbenz commented 6 years ago

Any idea why we hit it?

I think it is related to our code in NativeWindowMac listening to the NSScrollWheel events.

MarshallOfSound commented 6 years ago

/trop run backport-to electron-3-0-x

trop[bot] commented 6 years ago

The backport process for this PR has been manually initiated, sending your 1's and 0's to "electron-3-0-x" here we go! :D

trop[bot] commented 6 years ago

An error occurred while attempting to backport this PR to "electron-3-0-x", you will need to perform this backport manually