search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

fix: backport of process metrics fix from chromium #591

Closed torycl closed 6 years ago

torycl commented 6 years ago

Backport requested in and fixes https://github.com/electron/electron/issues/13605

PR created to check if it will start to work on CI machines. It always worked on local machines.

torycl commented 6 years ago

I have moved the diff from dchecks.patch to separate file. The function has moved in the chromium repo, so I have also fixed line numbers so it fits to out current Chromium version.

alexeykuzmin commented 6 years ago

/trop run backport-to "electron-3-0-x"

MarshallOfSound commented 6 years ago

@alexeykuzmin Trop won't work on unmerged PR's and it won't work in this repository without https://github.com/electron/libchromiumcontent/pull/593

MarshallOfSound commented 6 years ago

/trop run backport-to electron-3-0-x

MarshallOfSound commented 6 years ago

/trop run backport-to electron-3-0-x

trop[bot] commented 6 years ago

The backport process for this PR has been manually initiated, sending your 1's and 0's to "electron-3-0-x" here we go! :D

trop[bot] commented 6 years ago

An error occurred while attempting to backport this PR to "electron-3-0-x", you will need to perform this backport manually

alexeykuzmin commented 6 years ago

@torycl ^

alexeykuzmin commented 6 years ago

Trop won't work on unmerged PR's

yeah, I should get more sleep I guess =/ @MarshallOfSound

zcbenz commented 6 years ago

@torycl The crash still happens when running tests on Windows, currently the CI on master branch is failing after including this change:

python : [3224:0718/020420.879:FATAL:process_metrics_win.cc(332)] Check failed: result. : The handle is invalid. (0x6)