electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

build: [gn] export libgtkui symbols #598

Closed nornagon closed 6 years ago

nornagon commented 6 years ago

Without these, the GN build would throw errors like

ld.lld: error: undefined symbol: libgtkui::Gtk2StatusIcon::Gtk2StatusIcon(gfx::ImageSkia const&
, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&)
>>> referenced by tray_icon_gtk.cc:43 (../../electron/atom/browser/ui/tray_icon_gtk.cc:43)
>>>               tray_icon_gtk.o:(atom::TrayIconGtk::SetImage(gfx::Image const&)) in archive obj/electron/libelectron_lib.a