The GYP build uses a version of install-sysroot.py that was copied out of //build/linux/sysroot_scripts some time ago. This change will only affect GN, and it will cause the GN build to use the custom-built Electron sysroots, stored at http://s3.amazonaws.com/gh-contractor-zcbenz/toolchain and maintained by @zcbenz, instead of chromium's sysroots.
I'm not terribly satisfied with this solution, as it means we need to expend effort to maintain up-to-date sysroots. As far as I know, the only reason we build our own sysroot is to add the libnotify headers. Some other solutions that might allow us to use chromium's sysroot unmodified:
we could build an 'overlay' sysroot, which we could extract on top of the sysroot that chromium builds, with just the libnotify headers (and whatever other changes we need)
we could package libnotify headers in a different place and manually add them to the include paths of the targets that need them
The GYP build uses a version of
install-sysroot.pythat was copied out of//build/linux/sysroot_scriptssome time ago. This change will only affect GN, and it will cause the GN build to use the custom-built Electron sysroots, stored at http://s3.amazonaws.com/gh-contractor-zcbenz/toolchain and maintained by @zcbenz, instead of chromium's sysroots.I'm not terribly satisfied with this solution, as it means we need to expend effort to maintain up-to-date sysroots. As far as I know, the only reason we build our own sysroot is to add the
libnotifyheaders. Some other solutions that might allow us to use chromium's sysroot unmodified: