electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

build: update skia version to chrome/m63 in 2-0-x #603

Closed deepak1556 closed 6 years ago

deepak1556 commented 6 years ago

For fixing https://github.com/electron/electron/issues/13367 we need to backport the following patches on top skia for chrome/61.

https://skia-review.googlesource.com/c/skia/+/55381 https://skia-review.googlesource.com/c/skia/+/55800 https://skia-review.googlesource.com/c/skia/+/58580 https://skia-review.googlesource.com/c/skia/+/57660 https://skia-review.googlesource.com/c/skia/+/50040

Although the patches are minimal, they introduce a visible perf regression as indicated by the author in https://bugs.chromium.org/p/chromium/issues/detail?id=755871 and the perf fix landed in https://skia-review.googlesource.com/c/skia/+/60681 which went in ch63 but backporting it brings a couple of other patches which is not good for us. Thus this PR updates the skia version to the one used in ch63 and makes the relevant api changes which kept the patches to a minimal. Have already tested this with the vscode team to confirm fix of the issue.

/cc @bpasero @Tyriar

Fixes https://github.com/electron/electron/issues/13367

jkleinsc commented 6 years ago

@deepak1556 There seems to be an issue with the builds for this taking much longer and in some cases timing out after 3.5 hours: https://windows-ci.electronjs.org/project/AppVeyor/libchromiumcontent/build/1.0.1950 I restarted the build and it timed out the second time too: https://windows-ci.electronjs.org/project/AppVeyor/libchromiumcontent/build/1.0.1952

deepak1556 commented 6 years ago

The chromium team advices against this https://groups.google.com/a/chromium.org/d/msg/graphics-dev/_Zi_vxXpf7Q/tov4wNQ7BgAJ Also there were layouttests that got broken with this change.