electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

build: [gn win] link against static crt in non-component builds #610

Closed nornagon closed 6 years ago

nornagon commented 6 years ago

Fixes link errors of the form:

node.lib(node_lib.Protocol.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in atom_main.obj

This is because in the GN build, node is linked statically instead of dynamically in non-component builds.