fix: [gn] port crashpad patch from fork to patch

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

485 stars 183 forks source link

fix: [gn] port crashpad patch from fork to patch #620

Closed nornagon closed 6 years ago

nornagon commented 6 years ago

Since the GN build uses the crashpad that's referenced by Chromium's DEPS, port over the one semantic change from Electron's crashpad fork to be a patch.

MarshallOfSound commented 6 years ago

I can't rerun the VSTS builds that broke, can you push up again to kick the builds 👍

MarshallOfSound commented 6 years ago

Also worth noting is this a thing that we could potentially upstream?

nornagon commented 6 years ago

Upstreaming attempt: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1167793

nornagon commented 6 years ago

Patch successfully upstreamed: https://chromium.googlesource.com/crashpad/crashpad/+/f540abb506acc7be53a4702f87d291930967d001. Can be removed when we pass M71.