search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

fix: implement ArrayBuffer Realloc #625

Closed codebytere closed 6 years ago

codebytere commented 6 years ago

This PR is done in concert with this commit in the v10.6.0 Node upgrade for Chromium 67 to allow for overwriting of ReallocateBufferMemory to use v8's allocator.

alexeykuzmin commented 6 years ago

https://circleci.com/gh/electron/libchromiumcontent/9602

fatal: corrupt patch at line 33 add_realloc.patch failed to apply

alexeykuzmin commented 6 years ago

Is it possible to upstream this change?

codebytere commented 6 years ago

@alexeykuzmin good q, i'll try to find out by asking a v8 person. i think i left off a newline, will fix

alexeykuzmin commented 6 years ago

The builds still fail trying to apply the patch. I don't want to approve something that is bound to change )

alexeykuzmin commented 6 years ago 
error: patch failed: src/v8/include/v8.h:4318
error: src/v8/include/v8.h: patch does not apply
add_realloc.patch failed to apply
alexeykuzmin commented 6 years ago

@codebytere Build still fail =(