search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

fix: [mas] remove usage of private APIs #633

Closed nornagon closed 6 years ago

nornagon commented 6 years ago

See electron/electron#13957

nornagon commented 6 years ago

hrm, heads up, this patch causes some gfx_unittests to fail upstream: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/111640

Gonna see if i can figure out what's going on.

nornagon commented 6 years ago

Looks like my assessment that _CFIsObjC always returns 0 was wrong. Going to have to find another workaround.