search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

chore: roll clang 307486:308728 #643

Closed nornagon closed 6 years ago

nornagon commented 6 years ago

See upstream:

https://chromium-review.googlesource.com/c/chromium/src/+/582074

We don't need any of the other changes from that CL, because they're all fuchsia- or iOS-only.

Ref electron/electron#13988

K900 commented 6 years ago

Well, this is unfortunate :(

The error seems really weird, too - it's like the system libstdc++ is actually somehow newer than what ships with this Clang roll?

deepak1556 commented 6 years ago

The error seems to be fixed in https://chromium-review.googlesource.com/c/chromium/src/+/582976 , so using 308728-3 should be good for us.

K900 commented 6 years ago

Nice. @nornagon you want to try that roll with libcc before I try it with Electron itself?

nornagon commented 6 years ago

Updated the patch to refer to 308728-3.

nornagon commented 6 years ago

I'll wait on @deepak1556 to merge this when ready.

K900 commented 6 years ago

Does this need to go in first, and then the submodule on the Electron PR needs to be updated?

nornagon commented 6 years ago

Yep, that's accurate.

K900 commented 6 years ago

Then I guess we need to make some sort of a final call on whether this is worth merging, both here and on Electron itself.