Closed alexeykuzmin closed 6 years ago
@deepak1556 What kind of errors that DCHECKs used to cause?
There is only one incorrect usage of it left in the electron codebase https://github.com/electron/electron/blob/master/atom/browser/net/js_asker.h#L79, but that requires a refactor of that particular class to actually fix it.
That DCHECK still has to be enabled, but I'm going to close the PR to reduce noise in the repo.
Description of Change
It's in the title.
Checklist
script/update
runs without error