electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

[wip] build: enable a DCHECK in base/memory/weak_ptr.cc #656

Closed alexeykuzmin closed 6 years ago

alexeykuzmin commented 6 years ago
Description of Change

It's in the title.

Checklist
alexeykuzmin commented 6 years ago

@deepak1556 What kind of errors that DCHECKs used to cause?

deepak1556 commented 6 years ago

There is only one incorrect usage of it left in the electron codebase https://github.com/electron/electron/blob/master/atom/browser/net/js_asker.h#L79, but that requires a refactor of that particular class to actually fix it.

alexeykuzmin commented 6 years ago

That DCHECK still has to be enabled, but I'm going to close the PR to reduce noise in the repo.