search

electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

perf: commit our patches in batches instead of 1 by 1 #658

Closed MarshallOfSound closed 6 years ago

MarshallOfSound commented 6 years ago

This updates @alexeykuzmin's commit logic to commit our patches in batches so that we don't run commit a lot of times on a massive repo. This drops the re-sync time from 10 minutes to 2 minutes on my local machine, disabling commits drops it to 1min 52 seconds so this is wayyy better now 👍

alexeykuzmin commented 6 years ago

@MarshallOfSound @jkleinsc

This change makes git blame useless for our changes. One won't be able to tell from which patch a change comes from and who's its author.

Also it makes it more difficult to update a patch, you won't be able to simply make a change, amend a commit, and save the commit as a patch file.

But I understand that slowing builds down is not a good thing either. So it would be great to come up with some compromise solution that wouldn't create unnecessary complications for the development workflow.

MarshallOfSound commented 6 years ago

So it would be great to come up with some compromise solution that wouldn't create unnecessary complications for the development workflow.

Putting this change behind a flag that's enabled by default would probably be the best solution. Most people will be 👌 with the faster builds and those like need to git blame inside chromium can do it by syncing with a different flag