build: disable a DCHECK in viz::ServerSharedBitmapManager

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

485 stars 183 forks source link

build: disable a DCHECK in viz::ServerSharedBitmapManager #662

Closed alexeykuzmin closed 6 years ago

alexeykuzmin commented 6 years ago

It gets constantly triggered on Windows CI, e.g. https://windows-ci.electronjs.org/project/AppVeyor/electron-i8wjp/build/1.0.91 We expect that backporting of https://chromium-review.googlesource.com/802574 should fix it.

Description of Change

Checklist

[x] PR description included and stakeholders cc'd
[x] Patch information is added to appropriate .patches.yaml
[x] script/update runs without error
[x] PR title follows semantic commit guidelines

deepak1556 commented 6 years ago

Just adding a note for reviewers, the backport is planned after ch67 is merged. Also the failure only happens on ci, running the GN testing builds locally with all gpu stuff disabled behind --disable-gpu --disable-gpu-compositing --disable-gpu-early-init still doesn't trigger the crash, we are unable to isolate the reason for this, so the plan is to backport that CL which fixes some ownership of ServerSharedBitmapManager class.