build: [gyp] explicitly override rtc_use_h264 - Githubissues

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

486 stars 183 forks source link

build: [gyp] explicitly override rtc_use_h264 #667

Closed deepak1556 closed 6 years ago

deepak1556 commented 6 years ago

Description of Change

The flag got guarded behind is_chrome_banded in https://webrtc-review.googlesource.com/c/src/+/36321 , although it got reverted in https://webrtc-review.googlesource.com/c/src/+/62380 we cannot be sure that might not happen in future for the reasoning in that CL. So we explicitly override it, whenever we build with proprietary_codecs

Fixes https://github.com/electron/electron/issues/14256

Checklist

[x] PR description included and stakeholders cc'd
[x] Patch information is added to appropriate .patches.yaml
[x] script/update runs without error
[x] PR title follows semantic commit guidelines