electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

fix: proxy resolution from pac file for ws requests on windows and macOS (3-0-x) #696

Closed deepak1556 closed 5 years ago

deepak1556 commented 5 years ago
Description of Change

Backports https://chromium-review.googlesource.com/c/chromium/src/+/1143093 Fixes https://github.com/electron/electron/issues/15344

This is not required for versions greater than 3.x because we changed to use chromium proxy resolver implementation with https://github.com/electron/electron/pull/14656

And also it is not required for versions less than 3.x as the switch to platform proxy resolver was made temporarily only for ch 66 upgrade due to lack of support for mojo network context apis.

Checklist
ckerr commented 5 years ago

@deepak1556 thanks for the description of why this isn't needed except for in 3.x :+1: