fix: backport patch to fix scrolling problem (2-0-x)

zcbenz commented 5 years ago

Backport https://github.com/electron/electron/pull/15830 to 2-0-x.

Refs https://github.com/electron/electron/issues/8960.

Notes: Fix support for precision trackpad/mouse scrolling on Windows.

bpasero commented 5 years ago

Awesome 👍

ckerr commented 5 years ago

@zcbenz any idea about this?

[12353/18056] CXX obj/media/capture/capture_base/video_capture_types.obj
[12354/18056] CXX obj/gpu/ipc/service/ipc_service_sources/child_window_surface_win.obj
FAILED: obj/gpu/ipc/service/ipc_service_sources/child_window_surface_win.obj 
C:/Python27/python.exe ../../build/toolchain/win/tool_wrapper.py cl-wrapper ninja -t msvc -e environment.x86 -- "c:\program files (x86)\microsoft visual studio 14.0\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes  @obj/gpu/ipc/ser
vice/ipc_service_sources/child_window_surface_win.obj.rsp /c ../../gpu/ipc/service/child_window_surface_win.cc /Foobj/gpu/ipc/service/ipc_service_sources/child_window_surface_win.obj obj/gpu/ipc/service "ipc_service_sources_cc.pd
b"
../../gpu/ipc/service/child_window_surface_win.cc(154): error C2039: 'ClearInvalidContents': is not a member of 'gpu::ChildWindowWin'
C:\projects\libchromiumcontent-wqq1s\src\gpu/ipc/service/child_window_win.h(20): note: see declaration of 'gpu::ChildWindowWin'
../../gpu/ipc/service/child_window_surface_win.cc(164): error C2039: 'ClearInvalidContents': is not a member of 'gpu::ChildWindowWin'
C:\projects\libchromiumcontent-wqq1s\src\gpu/ipc/service/child_window_win.h(20): note: see declaration of 'gpu::ChildWindowWin'

zcbenz commented 5 years ago

I have fixed the compilation error, but it seems that the mac CI machines are failing because of S3 errors:

Job Build_libchromiumcontent: Step references task 'AmazonWebServices.aws-vsts-tools.S3Upload.S3Upload' at version '1' which does not exist.

/cc @jkleinsc

electron / libchromiumcontent

fix: backport patch to fix scrolling problem (2-0-x) #707