fix: Always create cookie store with network context (3-1-x)

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

486 stars 183 forks source link

fix: Always create cookie store with network context (3-1-x) #725

Closed deepak1556 closed 5 years ago

deepak1556 commented 5 years ago

Description of Change

Backports https://crrev.com/c/1152083 Ref https://github.com/electron/electron/pull/15836

Checklist

[x] PR description included and stakeholders cc'd
[x] Patch information is added to appropriate .patches.yaml
[x] script/update runs without error
[x] PR title follows semantic commit guidelines

felixrieseberg commented 5 years ago

../../services/network/network_context.cc:323:12: error: member reference type 'network::URLRequestContextBuilderMojo *' is a pointer; did you mean to use '->'?
    builder.SetCookieAndChannelIdStores(std::move(cookie_store),
    ~~~~~~~^
           ->

deepak1556 commented 5 years ago

@codebytere lets merge this, the 3-1-x libcc bump will use the merge commit and these builds are useless.